[PATCH] D73143: [scudo][standalone] Reduce Android region sizes to 128MB

Mitch Phillips via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 21 15:00:00 PST 2020


hctim added a comment.

> This is unfortunately one of those situations where we have to bend to
>  existing code because we doubt it's going to change any time soon.

:'(

Apparently this was fixed in Unity 5.4.1 (feedback post only available on WaybackArchive <https://web.archive.org/web/20180214170543/https://feedback.unity3d.com/suggestions/fix-16gb-memory-limit-on-linux>). You can see the patchnotes here <https://unity3d.com/unity/whats-new/unity-5.4.1> which mentions: `Linux: Removed 16GB total memory limit.`.

Instead of bending to old apps, could we consider potentially gating either a Scudo specific config, or Scudo in general (over jemalloc) on AppCompat platform version? We are doing this for Tagged Pointers currently in an attempt not to break old apps. The former seems like a much better option, as the latter requires us to maintain jemalloc on Android for the foreseeable future to use as a fallback allocator for old apps.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73143/new/

https://reviews.llvm.org/D73143





More information about the llvm-commits mailing list