[PATCH] D73144: [SVE] Pass Scalable argument to VectorType::get in Bitcode Reader

[Christopher Tetreault via Phabricator via llvm-commits]

ctetreau created this revision.
Herald added subscribers: llvm-commits, psnobl, rkruppe, hiraditya, tschuett.
Herald added a reviewer: efriedma.
Herald added a project: LLVM.
ctetreau added reviewers: pcc, sdesmalen, apazos, huihuiz, chrisj, thakis.
ctetreau marked an inline comment as done.
ctetreau added inline comments.


================
Comment at: llvm/lib/Bitcode/Reader/BitcodeReader.cpp:4175
       FullTy = VectorType::get(FullTy->getVectorElementType(),
-                               Mask->getType()->getVectorNumElements());
+                               Mask->getType()->getVectorElementCount());
       InstructionList.push_back(I);
----------------
This is the source of the bug from last patch. I passed the length of Vec1, not of the mask, which is not in line with the documented behavior of shufflevector or the original code.


- Pass the Scalability test to VectorType::get in order to be

able to deserialize bitcode that contains scalable vector operations


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D73144

Files:
  llvm/lib/Bitcode/Reader/BitcodeReader.cpp
  llvm/test/Bitcode/vscale-round-trip.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73144.239438.patch
Type: text/x-patch
Size: 4668 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200121/3aceffc9/attachment.bin>