[PATCH] D72808: [mlir] [VectorOps] Lowering of vector.extract/insert_slices to LLVM IR

[Aart Bik via Phabricator via llvm-commits]

aartbik added a comment.

PTAL

This new approach directly uses the canonicalization for vector.tuple_get on a tuple (so no need to dup the rule!). Furthermore, by using the vector to vector rewriting prior to the lowering, the introduction of a vector tuple is completely transparent, since subsequent rewriting removes them again. An additional advantage is that we get DCE for free, so need to introduce a DCE for just vector.tuple. The introduction of DCE forced me to fix a few test cases with dead code (good to do that anyway).

Note, since this code is much more structured, I also introduced vector.insert_slices in addition to vector_extract_slices, so that the final mechanism becomes more apparent.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72808/new/

https://reviews.llvm.org/D72808