[PATCH] D73130: [mlir] Strawman PR for shared library support

Tue Jan 21 13:10:19 PST 2020

stephenneuendorffer added a comment.

Thanks for looking into this!

================
Comment at: mlir/tools/mlir-shlib/CMakeLists.txt:11
+
+set(LIBS
+  MLIRAnalysis
----------------
I think the right thing to do is to add an add_mlir_library command, similar to D72554 which is used in the other CMakeFiles, so this list does not need to be maintained separately from where the libraries are declared.  

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73130/new/

https://reviews.llvm.org/D73130