[PATCH] D72938: Fix an assertion failure in DwarfExpression's subregister composition

[Adrian Prantl via Phabricator via llvm-commits]

aprantl marked 4 inline comments as done.
aprantl added inline comments.


================
Comment at: llvm/test/DebugInfo/MIR/ARM/subregister-full-piece.mir:39
+    t2Bcc %bb.2.for.body, 0, killed $cpsr, debug-location !260
+    DBG_VALUE $q8, 0, !139, !DIExpression(DW_OP_plus_uconst, 208, DW_OP_LLVM_fragment, 0, 64), debug-location !260
+    tB %bb.2.for.body, 14, $noreg
----------------
vsk wrote:
> Why is the DW_OP_plus_uconst needed?
This isn't strictly necessary. It was there in the testcase I reduced this from, and I thought it was needed to go down the HasComplexExpression() path, but the test also works without it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72938/new/

https://reviews.llvm.org/D72938