[PATCH] D72798: [llvm][docs] LangRef for IR attribute `vector-function-abi-variants`.

Francesco Petrogalli via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 21 12:51:32 PST 2020


fpetrogalli added inline comments.


================
Comment at: llvm/docs/LangRef.rst:1878
+
+         _ZGV<isa><mask><vlen><parameters>_<scalar_name>{(<vector_redirection>)}
+
----------------
jdoerfert wrote:
> 1) Only `CallInst` or call site?
> 2) Do we have a mangling doc entry that we could link to?
> 3) Do the `{` and `(` belong to the token stream? Maybe `[` is better to indicate optional things?

> Only CallInst or call site?

I am not sure what the distinction is. For now we are in need of it only for CallInst. What would be a call site?


> Do we have a mangling doc entry that we could link to?

The aarch64 and x86 ones are linked below. For LLVM, this piece of docs is to be considered the mangling doc.

> Do the { and ( belong to the token stream? Maybe [ is better to indicate optional things?

I'll use `[` for optional instead of `{`.





Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72798/new/

https://reviews.llvm.org/D72798





More information about the llvm-commits mailing list