[PATCH] D71907: [WPD/VFE] Always emit vcall_visibility metadata for -fwhole-program-vtables

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson marked an inline comment as done.
tejohnson added inline comments.


================
Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:676
+  bool ShouldEmitWPDInfo = CGM.getCodeGenOpts().WholeProgramVTables &&
+                           CGM.HasHiddenLTOVisibility(RD);
   llvm::Value *VirtualFn = nullptr;
----------------
evgeny777 wrote:
> Why are we checking for hidden visibility here?
This one is leftover from an earlier attempt at doing something more clever during GlobalOpt to decide whether we should be doing VFE or not, and I eventually abandoned that as it didn't work well, and went with the module flag here. You're right that we should be emitting the type test here under WholeProgramVtables, and not just with hidden visibility, but that belongs in D71913 (where I make the other change to insert type tests without hidden visibility). I've removed this change from this patch and am going to add it along with a test to that later patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71907/new/

https://reviews.llvm.org/D71907