[PATCH] D73122: [mlir] Enable specifying verify on OpInterface

[River Riddle via Phabricator via llvm-commits]

rriddle added inline comments.


================
Comment at: mlir/include/mlir/Analysis/InferTypeOpInterface.td:65
+  let verify = [{
+    return detail::verifyInferredResultTypes($_op);
+  }];
----------------
Is '$_op' documented somewhere?


================
Comment at: mlir/include/mlir/IR/OpBase.td:1417
+
+  // Specify the body of the verification function. `$_op` will be replaced with
+  // the operation being verified.
----------------
Why the underscore?


================
Comment at: mlir/include/mlir/IR/OpBase.td:1445
   code defaultBody = defaultImplementation;
+
+
----------------
Why the newlines?


================
Comment at: mlir/tools/mlir-tblgen/OpInterfacesGen.cpp:160
+          formatv("'verifyTrait' method cannot be specified as interface "
+                  "method for '{0}'; set verify on OpInterfaceTrait instead",
+                  interfaceName));
----------------
nit: verify -> 'verify' field


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73122/new/

https://reviews.llvm.org/D73122