[PATCH] D73044: {tablegen] Emit string literals instead of char arrays

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added inline comments.


================
Comment at: utils/TableGen/CMakeLists.txt:64
+# [1] https://docs.microsoft.com/en-us/cpp/cpp/compiler-limits?view=vs-2017
+if (NOT CMAKE_CROSSCOMPILING AND NOT MSVC)
+  set(TABLEGEN_EMIT_LONG_STR_LITERALS ON)
----------------
There's no need to check the crosscompiling flag any longer. If the compiler that will compile the generated code is msvc (be it cross or not), we need the legacy mode, but if crosscompiling with something else, we can generate the more efficient code.

I would suggest dropping this bit of the change altogether (and the tablegen-config.h file). The parameter when invoking the tool should always know precisely whether it's needed or not.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73044/new/

https://reviews.llvm.org/D73044