[PATCH] D72977: [mlir][ods] Fix StringRef initialization in builders

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 21 10:49:17 PST 2020


rriddle accepted this revision.
rriddle added inline comments.
This revision is now accepted and ready to land.


================
Comment at: mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp:990
+        // wrapping quotes.
+        if (StringRef(builderTemplate).contains("\"$0\"")) {
+          builderTemplate = replaceAllSubstrs(builderTemplate, "\"$0\"", "$0");
----------------
Remove trivial brace.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72977/new/

https://reviews.llvm.org/D72977





More information about the llvm-commits mailing list