[PATCH] D72721: [BranchAlign] Disable autopadding in cold blocks to reduce code size impact

Tue Jan 21 10:29:51 PST 2020

reames planned changes to this revision.
reames added a comment.

In D72721#1825665 <https://reviews.llvm.org/D72721#1825665>, @LuoYuanke wrote:

> @reames 
>  I'm a little bit concerned about the performance impact of this patch. Do you  have any data for the patch? Is there any performance penalty and how much code size is reduced?

Can you expand a little bit on your concern?  This is driven by profile data and only applies if that data is available.  If it is, it suppresses additional padding only in blocks thought to be globally cold.

JYI, I've had to context switch away from this, so it'll be a couple of days before I can meaningfully address review comments.`monospaced text`

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72721/new/

https://reviews.llvm.org/D72721