[PATCH] D73071: [X86] Support -fpatchable-function-entry=N,M where M>0

[Nick Desaulniers via Phabricator via llvm-commits]

nickdesaulniers added inline comments.


================
Comment at: llvm/lib/Target/X86/X86MCInstLower.cpp:2646
+  while (N--)
+    OutStreamer->EmitInstruction(MCInstBuilder(X86::NOOP), getSubtargetInfo());
+}
----------------
See comments on D73070 about making nop emission generic.


================
Comment at: llvm/test/CodeGen/X86/patchable-function-entry-ibt.ll:38
+; CHECK-NEXT: retq
+; CHECK:      .size f1_1, .Lfunc_end2-f1_1
+; CHECK:      .section __patchable_function_entries,"awo", at progbits,f1,unique,0
----------------
Need to know where `.Lfunc_end2` is placed, please add a `CHECK` for it.


================
Comment at: llvm/test/CodeGen/X86/patchable-function-entry.ll:82
+;; .size does not include the prefix.
+; CHECK:       .size f3_2, .Lfunc_end5-f3_2
+; NOFSECT      .section __patchable_function_entries,"awo", at progbits,f0,unique,0
----------------
Ditto.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73071/new/

https://reviews.llvm.org/D73071