[PATCH] D73100: [LLD][ELF][ARM] Don't apply --fix-cortex-a8 to relocatable links.
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 21 09:59:20 PST 2020
MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.
I was waiting for other opinions on D72968 <https://reviews.llvm.org/D72968> because I was thinking whether it makes sense to reject `-r --fix-*`. It seems GNU ld has made a decision and the way is simple, let's do this.
================
Comment at: lld/test/ELF/arm-fix-cortex-a8-recognize.s:14
+// RUN: ld.lld --fix-cortex-a8 -r %t.o -o %t3
+// RUN: llvm-objdump --no-show-raw-insn -d %t3 --start-address=0xffa --stop-address=0x1002 | FileCheck --check-prefix=CHECK-RELOCATABLE %s
----------------
peter.smith wrote:
> grimar wrote:
> > Does it make sense to check what we do with `-verbose -r`?
> There is a small benefit. I'll add a check that we don't see the message as it makes it more consistent with the others.
-v --> --verbose
They are different options. -v just prints the version number.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73100/new/
https://reviews.llvm.org/D73100
More information about the llvm-commits
mailing list