[PATCH] D73070: Add function attribute "patchable-function-prefix" to support -fpatchable-function-entry=N,M where M>0

Peter Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 21 09:48:39 PST 2020


peter.smith added a comment.

In D73070#1830367 <https://reviews.llvm.org/D73070#1830367>, @MaskRay wrote:

> -fpatchable-function-entry=N,M (where M>0) + -mbranch-protection=bti is quite clear (https://gcc.gnu.org/ml/gcc-patches/2020-01/msg01185.html).
>
> For -fpatchable-function-entry=N,0 + -mbranch-protection=bti/-fcf-protection=branch, if you have preference for placement (a) or (b), please make a comment:) and/or reply at https://gcc.gnu.org/ml/gcc-patches/2020-01/msg01185.html
>  If you are not subscribed to the gcc-patches mailing list (like me), you will have to download the raw email file `Other format:	[Raw text]` and reply...
>
> (b) will require separate patches.


FWIW it looks like GCC have gone with (b) https://gcc.gnu.org/ml/gcc-patches/2020-01/msg01348.html , FWIW my sentiments tend towards the argument given in https://gcc.gnu.org/ml/gcc-patches/2020-01/msg01322.html for option b.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73070/new/

https://reviews.llvm.org/D73070





More information about the llvm-commits mailing list