[PATCH] D71293: AMDGPU: Generate the correct sequence of code for FDIV32 when correctly-rounded-divide-sqrt is set

[Changpeng Fang via Phabricator via llvm-commits]

cfang marked 3 inline comments as done.
cfang added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUCodeGenPrepare.cpp:603
   bool UnsafeDiv = HasUnsafeFPMath || FMF.isFast() ||
                                       FMF.allowReciprocal();
   // With UnsafeDiv node will be optimized to just rcp and mul.
----------------
arsenm wrote:
> I don't think just allow reciprocal is sufficient without either checking FPMath or afn. I think this needs to be something more like
> UnsafeFP || isFast || (allowReciprocal && (denormal hasLowAccuracy || approximateFunction))
Can you explain what is exactly "denormal hasLowAccuracy" here?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71293/new/

https://reviews.llvm.org/D71293