[PATCH] D71911: [ThinLTO] Summarize vcall_visibility metadata

Eugene Leviant via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 21 07:55:09 PST 2020


evgeny777 added inline comments.


================
Comment at: llvm/include/llvm/IR/ModuleSummaryIndex.h:762
+        bool ReadOnly, bool WriteOnly, bool Constant,
+        GlobalObject::VCallVisibility Vis = GlobalObject::VCallVisibilityPublic)
         : MaybeReadOnly(ReadOnly), MaybeWriteOnly(WriteOnly),
----------------
I think using default parameter is error prone here. Can you please get rid of it and update all places of usage respectively?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71911/new/

https://reviews.llvm.org/D71911





More information about the llvm-commits mailing list