[PATCH] D72999: [mlir][spirv] Simplify scalar type size calculation.

[Lei Zhang via Phabricator via llvm-commits]

antiagainst added inline comments.


================
Comment at: mlir/test/Conversion/StandardToSPIRV/std-to-spirv.mlir:297
+
+// CHECK-LABEL: func @memref_type({{%.*}}: !spv.ptr<!spv.struct<!spv.array<3 x i1 [1]> [0]>, {{.*}}>
+func @memref_type(%arg0 : memref<3xi1>) {
----------------
Hmm, we cannot have bool type in externally visible storage classes: https://www.khronos.org/registry/spir-v/specs/unified1/SPIRV.html#OpTypeBool.

This is something that should be fixed. Could you just change to reject memref of booleans for now?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72999/new/

https://reviews.llvm.org/D72999