[PATCH] D72067: [PowerPC] Delete PPCSubtarget::isDarwin and isDarwinABI

[Sean Fertile via Phabricator via llvm-commits]

sfertile accepted this revision as: sfertile.
sfertile added a comment.
This revision is now accepted and ready to land.

Thanks for doing this cleanup. LGTM.



================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:14809
   Register Reg = StringSwitch<Register>(RegName)
                    .Case("r1", is64Bit ? PPC::X1 : PPC::R1)
+                   .Case("r2", isPPC64 ? Register() : PPC::R2)
----------------
Minor nit: since we are touching this switch anyway we should format it as the Lint check suggests so we don't keep getting the warning in other patches touching this file.


================
Comment at: llvm/lib/Target/PowerPC/PPCSubtarget.h:292
+  // PPC32 SVR4ABI has no red zone and PPC64 SVR4ABI has a 288-byte red zone.
   unsigned  getRedZoneSize() const {
+    return isPPC64() ? 288 : 0;
----------------
Ditto on the formatting.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72067/new/

https://reviews.llvm.org/D72067