[PATCH] D73096: [llvm-readobj] - Rewrite gnuhash.test test to stop using precompiled objects.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM.

In D73096#1831007 <https://reviews.llvm.org/D73096#1831007>, @grimar wrote:

> I've also added tests for llvm-readelf to document the behavior,
>  though I do not understand why it accepts `--gnu-hash-table`.
>  GNU readelf does not. Is it a bug?


I wouldn't call it a bug. Rather, it's a feature. If you just want to dump the contents of the .gnu.hash section (and not the .hash section), you need this sort of switch. I think it's okay for us to have switches that are not accepted in GNU readelf, as long as the switch names are (relatively) unlikely to be used by GNU for something else in the future. I do however find it weird that the GNU and LLVM styles match.



================
Comment at: llvm/test/tools/llvm-readobj/ELF/gnuhash.test:47
+        Value: 0x0
+DynamicSymbols:
+  - Name:    aaa
----------------
Are the dynamic symbols needed for the test?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73096/new/

https://reviews.llvm.org/D73096