[PATCH] D73100: [LLD][ELF][ARM] Don't apply --fix-cortex-a8 to relocatable links.
Peter Smith via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 21 07:16:52 PST 2020
peter.smith marked an inline comment as done.
peter.smith added a comment.
In D73100#1831139 <https://reviews.llvm.org/D73100#1831139>, @grimar wrote:
> It looks fine to me, I'll leave it for others, have a minor question though.
================
Comment at: lld/test/ELF/arm-fix-cortex-a8-recognize.s:14
+// RUN: ld.lld --fix-cortex-a8 -r %t.o -o %t3
+// RUN: llvm-objdump --no-show-raw-insn -d %t3 --start-address=0xffa --stop-address=0x1002 | FileCheck --check-prefix=CHECK-RELOCATABLE %s
----------------
grimar wrote:
> Does it make sense to check what we do with `-verbose -r`?
There is a small benefit. I'll add a check that we don't see the message as it makes it more consistent with the others.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73100/new/
https://reviews.llvm.org/D73100
More information about the llvm-commits
mailing list