[PATCH] D72977: [mlir][ods] Fix StringRef initialization in builders

[Lei Zhang via Phabricator via llvm-commits]

antiagainst marked 2 inline comments as done.
antiagainst added inline comments.


================
Comment at: mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp:98
+/// splitting. If a segment is empty, it will be omitted.
+static void splitString(StringRef input, StringRef delimiter,
+                        llvm::SmallVectorImpl<StringRef> &outputs) {
----------------
rriddle wrote:
> Why not just add a replaceAllSubStrs using std::string instead? Generally only takes ~5 lines of code.
Sure, that works too. Changed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72977/new/

https://reviews.llvm.org/D72977