[PATCH] D71337: [VE,#0] 64bit data for SjLj

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 21 05:17:42 PST 2020


arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/TargetPassConfig.cpp:698-702
+    if (TM->getTargetTriple().isVE())
+      addPass(createSjLjEHPreparePass(true));
+    else
+      addPass(createSjLjEHPreparePass());
     LLVM_FALLTHROUGH;
----------------
I would expect this to be a target hook of some kind the pass checks, not a pass parameter controlled here. Checking a target triple here is probably not kosher


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71337/new/

https://reviews.llvm.org/D71337





More information about the llvm-commits mailing list