[PATCH] D73058: [LoopRotate] add ability to repeat loop rotation until non-deoptimizing exit is found

[Fedor Sergeev via Phabricator via llvm-commits]

fedor.sergeev marked an inline comment as done.
fedor.sergeev added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/LoopRotationUtils.cpp:570
+    // to handle multiple rotations in one go.
+    rotateLoop(L, false);
+  }
----------------
skatkov wrote:
> fedor.sergeev wrote:
> > skatkov wrote:
> > > Does'not you want to convert this recursion into iteration by moving this code to LoopRotate::processLoop?
> > Then it makes the patch looking much bigger than it actually is due to lots of whitespace changes.
> > I'm not sure it is worth the effort.
> > Perhaps do that separately?
> > The only benefit is that in loop form it becomes super-easy to limit amount of iterations.
> > 
> Ok, but still I like iterations more than recursions here.
I'm gonna try iterations and see how bad it is :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73058/new/

https://reviews.llvm.org/D73058