[PATCH] D72843: [llvm-readelf][llvm-readobj] - Fix the indentation when printing dynamic tags.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM with a couple of nits.



================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:4000
+  // The "Name/Value" column should be indented from the "Type" column by N
+  // whitespaces, where N = MaxTagSize - length of "Type" (4) + trailing
+  // whitespace (1) = 3.
----------------
whitespaces -> spaces


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:4001
+  // whitespaces, where N = MaxTagSize - length of "Type" (4) + trailing
+  // whitespace (1) = 3.
+  OS << "  Tag" + std::string(ELFT::Is64Bits ? 16 : 8, ' ') + "Type"
----------------
whitespace -> space


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:5806-5807
+  // The "Name/Value" column should be indented from the "Type" column by N
+  // whitespaces, where N = MaxTagSize - length of "Type" (4) + trailing
+  // whitespace (1) = -3.
+  W.startLine() << "  Tag" << std::string(ELFT::Is64Bits ? 16 : 8, ' ')
----------------
Same comments as above.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72843/new/

https://reviews.llvm.org/D72843