[PATCH] D73083: [llvm-exegesis] Add support for AVX512 explicit rounding operands.

Guillaume Chatelet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 21 02:38:23 PST 2020


gchatelet accepted this revision.
gchatelet added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/unittests/tools/llvm-exegesis/X86/SnippetGeneratorTest.cpp:211
+  auto Configs = Generator.generateConfigurations(Instr, State.getRATC().emptyRegisters());
+  ASSERT_FALSE((bool)Configs.takeError());
+  ASSERT_THAT(*Configs, SizeIs(1));
----------------
nit: you don't need the cast to `bool` for `ASSERT_FALSE`, `ASSERT_TRUE`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73083/new/

https://reviews.llvm.org/D73083





More information about the llvm-commits mailing list