[PATCH] D72832: [NFC][LoopUtils] Added regression test for getEstimatedTripCount.

[Evgeniy via Phabricator via llvm-commits]

ebrevnov added a comment.

In D72832#1826038 <https://reviews.llvm.org/D72832#1826038>, @fhahn wrote:

> Could you describe why the changes to run the tests via the pass managers is required? Wouldn't it be sufficient to use initialize the required analysis for the function and use that with getLoopEstimatedTripCount?


They are not required. The thing is LoopUtilsTest.cpp didn't exist when I first developed my test. Later during one of the rebases I discovered that somebody else introduced a test with the same name. It didn't look right to me to do loop traversal in one test in two different ways. My personal preference was to use pass manager and I streamlined the code this way. Do you see any problems with that?

Optionally I can move my part to a separate file so they will be completely independent,.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72832/new/

https://reviews.llvm.org/D72832