[lld] b16f82a - Revert "[MachO] Add a test for detecting reserved unit length."

[Mitch Phillips via llvm-commits]

Author: Mitch Phillips
Date: 2020-01-20T22:39:24-08:00
New Revision: b16f82ad3b095070729cde2873bd3a2e8ab35c0e

URL: https://github.com/llvm/llvm-project/commit/b16f82ad3b095070729cde2873bd3a2e8ab35c0e
DIFF: https://github.com/llvm/llvm-project/commit/b16f82ad3b095070729cde2873bd3a2e8ab35c0e.diff

LOG: Revert "[MachO] Add a test for detecting reserved unit length."

This change broke the UBSan buildbots. More information available in the
original Phabricator review: https://reviews.llvm.org/D72695

This reverts commit fcc08aa835de1e0c1f3e7e479917575e55433b68.

Added: 
    

Modified: 
    lld/unittests/MachOTests/MachONormalizedFileToAtomsTests.cpp

Removed: 
    


################################################################################
diff  --git a/lld/unittests/MachOTests/MachONormalizedFileToAtomsTests.cpp b/lld/unittests/MachOTests/MachONormalizedFileToAtomsTests.cpp
index e90c0979d81d..cf9a845c4b26 100644
--- a/lld/unittests/MachOTests/MachONormalizedFileToAtomsTests.cpp
+++ b/lld/unittests/MachOTests/MachONormalizedFileToAtomsTests.cpp
@@ -97,41 +97,3 @@ TEST(ToAtomsTest, basic_obj_x86_64) {
   EXPECT_TRUE(atom4->name().equals("_undef"));
   EXPECT_EQ(lld::Atom::definitionUndefined, atom4->definition());
 }
-
-TEST(ToAtomsTest, reservedUnitLength) {
-  static const uint8_t debugInfoWithReservedLengthContent[12] = {
-      0xf0, 0xff, 0xff, 0xff // Reserved length value
-  };
-  static const uint8_t debugInfoWithValidBigLengthContent[12] = {
-      0xef, 0xff, 0xff, 0xff, // The maximum valid length value for DWARF32
-      0x00, 0x00              // Wrong version
-  };
-  static const uint8_t debugAbbrevDummyContent[] = {0x00};
-
-  NormalizedFile fReservedLength, fValidBigLength;
-  fReservedLength.arch = lld::MachOLinkingContext::arch_x86;
-  fValidBigLength.arch = lld::MachOLinkingContext::arch_x86;
-  Section section;
-  section.segmentName = "__DWARF";
-  section.sectionName = "__debug_info";
-  section.content = llvm::makeArrayRef(debugInfoWithReservedLengthContent);
-  fReservedLength.sections.push_back(section);
-  section.content = llvm::makeArrayRef(debugInfoWithValidBigLengthContent);
-  fValidBigLength.sections.push_back(section);
-  section.sectionName = "__debug_abbrev";
-  section.content = llvm::makeArrayRef(debugAbbrevDummyContent);
-  fReservedLength.sections.push_back(section);
-  fValidBigLength.sections.push_back(section);
-
-  auto resultReservedLength = normalizedToAtoms(fReservedLength, "foo", false);
-  auto resultValidBigLength = normalizedToAtoms(fValidBigLength, "foo", false);
-
-  // Both cases should return errors, but 
diff erent.
-  ASSERT_FALSE(resultReservedLength);
-  ASSERT_FALSE(resultValidBigLength);
-
-  EXPECT_STREQ("Malformed DWARF in foo",
-               toString(resultReservedLength.takeError()).c_str());
-  EXPECT_STREQ("Unsupported DWARF version in foo",
-               toString(resultValidBigLength.takeError()).c_str());
-}