[PATCH] D72522: [Hexagon] Add support for general dynamic relocs

[Brian Cain via Phabricator via llvm-commits]

bcain added a comment.

In D72522#1819964 <https://reviews.llvm.org/D72522#1819964>, @sidneym wrote:

> Update testcase.
>
> - Verify the absence of relocations in the executable.
> - hexagon may call tls_get_addr but the name is not explicitly stated in the ABI.  The internally maintained linker will create the symbol to call which is generally "__tls_get_addr".  There are instances when it would not be "__tls_get_addr" such as when a user built a static executable using objects built -shared -pic.  In such a case the internal linker would create a stub called __hexagon_ie_tls_get_addr and call it.  LLD for hexagon would not support doing this until some design could be agreed upon.
> - Don't check explicit addresses in GOT.
> - Added the check for the closing brace.


LGTM, @sidneym.  It would be more explicit if you marked the outstanding items on the review as 'DONE'.

@MaskRay / @ruiu what do you think?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72522/new/

https://reviews.llvm.org/D72522