[PATCH] D72997: [AMDGPU] SIRemoveShortExecBranches should not remove branches exiting loops

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 20 19:35:56 PST 2020


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIRemoveShortExecBranches.cpp:95
+      if (I->isConditionalBranch() &&
+          I->getOpcode() != AMDGPU::S_CBRANCH_EXECNZ)
         return true;
----------------
Special casing execnz just doesn't make sense to me. execz/execnz are morally equivalent


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72997/new/

https://reviews.llvm.org/D72997





More information about the llvm-commits mailing list