[PATCH] D71501: Cost Annotation Writer for InlineCost

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin added a comment.

lgtm



================
Comment at: llvm/lib/Analysis/InlineCost.cpp:103
+
+struct InliningCostDetail {int Cost; int Threshold;};
+
----------------
Nit: CostDelta / ThresholdDelta? (I realize I proposed 'Cost/Threshold' initially, but that was before understanding the usage further below)

Also nit: now that we have a struct, if we had CostBefore/CostAfter and ThresholdBefore/ThresholdAfter, the intent would be even more evident, and we could, if we wanted, also output the raw costs (i.e. costs and delta). But this could be done at a later stage, too.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71501/new/

https://reviews.llvm.org/D71501