[PATCH] D51589: DAG: Fold extract_vector_elt (scalar_to_vector), K to undef

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/test/CodeGen/AMDGPU/max.i16.ll:163-164
 ; GFX9-NEXT:    v_lshlrev_b32_e32 v4, 3, v0
+; GFX9-NEXT:    v_mov_b32_e32 v5, 0
+; GFX9-NEXT:    v_mov_b32_e32 v6, 0
 ; GFX9-NEXT:    s_waitcnt lgkmcnt(0)
----------------
I'm pretty sure these zeros are dead


================
Comment at: llvm/test/CodeGen/AMDGPU/max.i16.ll:173-175
+; GFX9-NEXT:    global_load_short_d16 v6, v[0:1], off offset:4
+; GFX9-NEXT:    global_load_dword v7, v[0:1], off
+; GFX9-NEXT:    global_load_dword v2, v[2:3], off
----------------
I think this for some reason just got luckier on scheduling


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D51589/new/

https://reviews.llvm.org/D51589