[PATCH] D72679: [ms] [llvm-ml] Add placeholder for llvm-ml, based on llvm-mc

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 20 07:03:55 PST 2020


thakis added a comment.

Only supporting x86 targets for llvm-ml makes sense to me. As far as I know, msvc doesn't have an ml.exe for arm64 either (?).



================
Comment at: llvm/test/tools/llvm-ml/basic.test:1
+# REQUIRES: x86-registered-target
+# RUN: not llvm-ml %t.blah -o /dev/null 2>&1 | FileCheck --check-prefix=ENOENT %s
----------------
This is an ok way of doing this, but since all tests in this directory are going to need it, it's a bit nicer to instead have a file called lit.local.cfg in this directory that contains:

```
if not ('X86' in config.root.targets):
    # We need support for X86.
    config.unsupported = True
```

Then all the tests in this dir will only run if X86 is in LLVM_TARGETS_TO_BUILD.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72679/new/

https://reviews.llvm.org/D72679





More information about the llvm-commits mailing list