[PATCH] D72997: [AMDGPU] SIRemoveShortExecBranches should not remove branches exiting loops

[Carl Ritson via Phabricator via llvm-commits]

critson added a comment.

In D72997#1829191 <https://reviews.llvm.org/D72997#1829191>, @cdevadas wrote:

> There is already a special check in function mustRetainExeczBranch, looking for loop code if the opcode is S_CBRANCH_VCCNZ & S_CBRANCH_VCCZ.
>  We should include S_CBRANCH_SCC0 & S_CBRANCH_SCC1 here. I hope this guarantees to be working for such cases.


That would work for my test case (essentially a slightly more complex version of lit test).
I am happy with your proposed change, if others agree then I will abandon this one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72997/new/

https://reviews.llvm.org/D72997