[PATCH] D72900: [DebugInfo] Support 64-bit DWARF for .debug_names.

[Igor Kudrin via Phabricator via llvm-commits]

ikudrin marked 3 inline comments as done.
ikudrin added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFAcceleratorTable.cpp:380
+                                       uint64_t *Offset) {
+  static const unsigned CommonHeaderSize = 2 + // Version
+                                           2 + // Padding
----------------
probinson wrote:
> Could this be `constexpr` ?
Done. Thanks!


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFAcceleratorTable.cpp:631
+      CUsBase +
+      SectionOffsetSize * (Hdr.CompUnitCount + Hdr.LocalTypeUnitCount) + 8 * TU;
   return Section.AccelSection.getU64(&Offset);
----------------
probinson wrote:
> Is this line too long?  (Did you run clang-format-diff?)
It is exactly 80 characters long. And yes, it is `clang-format` which made this formatting.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72900/new/

https://reviews.llvm.org/D72900