[PATCH] D72929: [SCEV] Swap guards estimation sequence. NFC

Daniil Fukalov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 20 05:49:42 PST 2020


This revision was automatically updated to reflect the committed changes.
Closed by commit rGde34b54edce4: [SCEV] Swap guards estimation sequence. NFC (authored by dfukalov).

Changed prior to commit:
  https://reviews.llvm.org/D72929?vs=238788&id=239098#toc

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72929/new/

https://reviews.llvm.org/D72929

Files:
  llvm/lib/Analysis/ScalarEvolution.cpp


Index: llvm/lib/Analysis/ScalarEvolution.cpp
===================================================================
--- llvm/lib/Analysis/ScalarEvolution.cpp
+++ llvm/lib/Analysis/ScalarEvolution.cpp
@@ -9222,9 +9222,11 @@
       !isAvailableAtLoopEntry(SplitRHS.first, MDL))
     return false;
 
-  return isLoopEntryGuardedByCond(MDL, Pred, SplitLHS.first, SplitRHS.first) &&
-         isLoopBackedgeGuardedByCond(MDL, Pred, SplitLHS.second,
-                                     SplitRHS.second);
+  // It seems backedge guard check is faster than entry one so in some cases
+  // it can speed up whole estimation by short circuit
+  return isLoopBackedgeGuardedByCond(MDL, Pred, SplitLHS.second,
+                                     SplitRHS.second) &&
+         isLoopEntryGuardedByCond(MDL, Pred, SplitLHS.first, SplitRHS.first);
 }
 
 bool ScalarEvolution::isKnownPredicate(ICmpInst::Predicate Pred,


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72929.239098.patch
Type: text/x-patch
Size: 905 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200120/1b69abcc/attachment.bin>


More information about the llvm-commits mailing list