[PATCH] D72798: [llvm][docs] LangRef for IR attribute `vector-function-abi-variants`.

[Andrzej Warzynski via Phabricator via llvm-commits]

andwar added inline comments.


================
Comment at: llvm/docs/LangRef.rst:1865
+    that a custom name is provided instead of the standard one
+    ``_ZGV<isa><mask><vlen><parameters>_<scalar_name>`` (custom names
+    can be provided for example via the use of ``declare variant`` in
----------------
> When present, the optional token ``(<vector_redirection>)`` informs the compiler that a custom name is provided instead of the standard one ``_ZGV<isa><mask><vlen><parameters>_<scalar_name>``

This sounds a bit odd:
* `a custom name is provided instead of the standard one` -> `a custom name is provided in addition to the standard one`? As far as the attribute is concerned, the custom name is something that's additional/optional, right. AFAIK, it's not there _instead_ of the standard name (but indeed, later will be used _instead_ of the standard name). Maybe worth claryfying?
* `the standard one _ZGV<isa><mask><vlen><parameters>_<scalar_name>` -> here you repeat the definition of the standard name, which was already specified in the previous sentence. Maybe just remove ``_ZGV<isa><mask><vlen><parameters>_<scalar_name>``? 




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72798/new/

https://reviews.llvm.org/D72798