[PATCH] D72838: [llvm-objdump] - Fix the indentation when printing dynamic tags.

[George Rimar via Phabricator via llvm-commits]

grimar marked an inline comment as done.
grimar added inline comments.


================
Comment at: llvm/test/tools/llvm-objdump/elf-dynamic-section.test:441
+# RUN: yaml2obj --docnum=4 %s > %t4
+# RUN: llvm-objdump -p %t4 | FileCheck %s --strict-whitespace --check-prefix=INDENT
+
----------------
MaskRay wrote:
> Delete `--strict-whitespace`.
> 
> Without `--match-full-lines`, the line beginning is not enforced by the "strict whitespace" rule.
Actually this test checks the indentation between "NEEDED" and "0x", not the
indentation at the line beginning (which is tested above). So it was correct I think.

I do not mind testing the indentation at the beginning just in case, so I've applied
your suggestion partially, but I can't remove  `--strict-whitespace` as it breaks the
test, because allows having any indentation between "NEEDED" and "0x".


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72838/new/

https://reviews.llvm.org/D72838