[PATCH] D72128: [llvm-objcopy][ELF] Allow setting SHF_EXCLUDE flag for ELF sections
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 20 00:53:23 PST 2020
jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.
Aside from the inline comment, this looks good to me. Might want to get @MaskRay to approve before committing though.
================
Comment at: llvm/test/tools/llvm-objcopy/ELF/rename-section-flag-preserved.test:72-73
# CHECK-NEXT: ]
-
-# BAD-FLAG: unrecognized section flag 'xyzzy'
----------------
I can see this is unreferenced in this test, but removing it shouldn't be part of this commit. Please make a separate change just deleting this line and the blank line above it, without need for further review.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72128/new/
https://reviews.llvm.org/D72128
More information about the llvm-commits
mailing list