[PATCH] D72928: [llvm-exegesis][NFC] Disassociate snippet generators from benchmark runners

Clement Courbet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 20 00:25:48 PST 2020


courbet accepted this revision.
courbet added a comment.
This revision is now accepted and ready to land.

Thanks.



================
Comment at: llvm/tools/llvm-exegesis/lib/SerialSnippetGenerator.cpp:11-19
-#include "Assembler.h"
-#include "BenchmarkRunner.h"
 #include "MCInstrDescView.h"
-#include "PerfHelper.h"
-#include "Target.h"
-#include "llvm/ADT/STLExtras.h"
-#include "llvm/MC/MCInst.h"
----------------
mstojanovic wrote:
> It's not easy to determine which headers are needed here when splitting the files. Most of them seem to be unused.
I could not find anything obvious that would require any of these and not already use din the header.

Headers are missing for `vector`, `iota` and `shuffle` though.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72928/new/

https://reviews.llvm.org/D72928





More information about the llvm-commits mailing list