[PATCH] D65761: Add Windows Control Flow Guard checks (/guard:cf).

Fri Jan 17 07:55:48 PST 2020

hubert.reinterpretcast added a comment.

In D65761#1814968 <https://reviews.llvm.org/D65761#1814968>, @ajpaverd wrote:

> The CFGuard library shouldn't be needed for targets other than ARM, AArch64, and X86, and it's only being built for these targets. However, it looks like `llvm-build` is also including it in the `LibraryDependencies.inc` file for other targets, such as PowerPC, which I think is causing this error. I'm not sure how to indicate that the library is only needed for a specified subset of targets. @rnk or @hans  any suggestions?

Is the CFGuard library meaningful to provide for the other targets? Is consistency in the availability of the library (e.g., in case of hardcoded `-l` in the Makefile of some LLVM-dependent project) desired? It may make sense to treat the library as not target-specific.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65761/new/

https://reviews.llvm.org/D65761