[PATCH] D72838: [llvm-objdump] - Fix the indentation when printing dynamic tags.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added inline comments.


================
Comment at: llvm/test/tools/llvm-objdump/elf-dynamic-section.test:437
+
+# RUN: yaml2obj --docnum=3 %s > %t3
+# RUN: llvm-objdump -p %t3 | FileCheck %s --strict-whitespace --check-prefix=INDENT
----------------
`>` -> `-o`

I think we tend to avoid output redirection if that can be achieved with small efforts.


================
Comment at: llvm/test/tools/llvm-objdump/elf-dynamic-section.test:441
+# RUN: yaml2obj --docnum=4 %s > %t4
+# RUN: llvm-objdump -p %t4 | FileCheck %s --strict-whitespace --check-prefix=INDENT
+
----------------
Delete `--strict-whitespace`.

Without `--match-full-lines`, the line beginning is not enforced by the "strict whitespace" rule.


================
Comment at: llvm/test/tools/llvm-objdump/elf-dynamic-section.test:443
+
+# INDENT:Dynamic Section:
+# INDENT:  NEEDED 0x
----------------
`# INDENT: {{^}}Dynamic Section:`


================
Comment at: llvm/test/tools/llvm-objdump/elf-dynamic-section.test:444
+# INDENT:Dynamic Section:
+# INDENT:  NEEDED 0x
+
----------------
`# INDENT: {{^}}  NEEDED 0x`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72838/new/

https://reviews.llvm.org/D72838