[PATCH] D72991: AMDGPU/R600: Emit rodata in text segment

[Jan Vesely via Phabricator via llvm-commits]

jvesely created this revision.
jvesely added a reviewer: arsenm.
Herald added subscribers: llvm-commits, kerbowa, hiraditya, t-tye, tpr, dstuttard, yaxunl, nhaehnle, wdng, kzhuravl.
Herald added a project: LLVM.

R600 relies on this behaviour.
Fixes: 6e18266aa4dd78953557b8614cb9ff260bad7c65 ('Partially revert D61491 <https://reviews.llvm.org/D61491> "AMDGPU: Be explicit about whether the high-word in SI_PC_ADD_REL_OFFSET is 0"')
Fixes ~100 piglit regressions since 6e18266


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D72991

Files:
  llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.cpp


Index: llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.cpp
===================================================================
--- llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.cpp
+++ llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.cpp
@@ -559,7 +559,7 @@
 }
 
 bool shouldEmitConstantsToTextSection(const Triple &TT) {
-  return TT.getOS() == Triple::AMDPAL;
+  return TT.getOS() == Triple::AMDPAL || TT.getArch() == Triple::r600;
 }
 
 int getIntegerAttribute(const Function &F, StringRef Name, int Default) {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72991.238974.patch
Type: text/x-patch
Size: 503 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200119/39f7182b/attachment.bin>