[PATCH] D72554: [mlir] support building with BUILD_SHARED_LIBS=ON

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jan 18 18:35:09 PST 2020


mehdi_amini added inline comments.


================
Comment at: mlir/cmake/modules/AddMLIR.cmake:11
+  # since MLIR cannot be built as shared libraries.
+  set(LIBTYPE STATIC)
+
----------------
With this, this patch is not changing anything to building with -DBUILD_SHARED_LIBS=ON, shouldn't we remove this line?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72554/new/

https://reviews.llvm.org/D72554





More information about the llvm-commits mailing list