[PATCH] D72957: [mlir] Unbreak MSVC build with implicit constructor

Frank Laub via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jan 18 12:34:49 PST 2020


flaub added a comment.

I think I found a solution to this, try:

  explicit attr_value_iterator(ArrayAttr::iterator it)
      : llvm::mapped_iterator<ArrayAttr::iterator, AttrTy (*)(Attribute)>(
            it, [](Attribute attr) { return attr.cast<AttrTy>(); }) {}

Apparently MSVC is confused about the unqualified `iterator` identifier. Qualifying it with `ArrayAttr::` seems to clear it up.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72957/new/

https://reviews.llvm.org/D72957





More information about the llvm-commits mailing list