[PATCH] D72679: [ms] [llvm-ml] Add placeholder for llvm-ml, based on llvm-mc

Eric Astor via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jan 18 10:35:41 PST 2020


epastor added a comment.

In D72679#1828069 <https://reviews.llvm.org/D72679#1828069>, @RKSimon wrote:

> In D72679#1828062 <https://reviews.llvm.org/D72679#1828062>, @epastor wrote:
>
> > Quick note: I've reverted this change in commit 0eeddf1ac59066567a096ad95344f43c38e6b04f <https://reviews.llvm.org/rG0eeddf1ac59066567a096ad95344f43c38e6b04f> due to the build breakages on all ARM platforms.
> >
> > @RKSimon If you have any advice for relanding this safely, it'd be much appreciated!
>
>
> Can you replicate the cmake settings in http://lab.llvm.org:8011/builders/llvm-clang-win-x-aarch64/builds/3114/steps/cmake-configure/logs/stdio ? The issue seems in part due to the available targets/triples:
>
>   llvm-ml.exe: error: : error: unable to get target for 'x86_64-pc-windows-msvc', see --version and --triple.
>


As mentioned in my earlier comment - I think the issue is ENTIRELY due to the available targets/triples, since this tool forces to the (i386|x86_64)-pc-windows-msvc targets/triples. It's designed to (eventually) mimic Microsoft's ml.exe. I can try to broaden it, but I'm concerned about functionality - MASM is a pretty specific assembly dialect. No chance you know a standard way to condition these targets on whether those triples are available?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72679/new/

https://reviews.llvm.org/D72679





More information about the llvm-commits mailing list