[PATCH] D72919: [AArch64] Add custom store lowering for 256 bit non-temporal stores.

[Dave Green via Phabricator via llvm-commits]

dmgreen added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.td:2727
 
+def : Pat<(AArch64stnp FPR128:$Rt, FPR128:$Rt2, (am_indexed7s64 GPR64sp:$Rn, simm7s8:$offset)),
+          (STNPQi FPR128:$Rt, FPR128:$Rt2, GPR64sp:$Rn, simm7s8:$offset)>;
----------------
Should this be simm7s16? Same for am_indexed7s128


================
Comment at: llvm/test/CodeGen/AArch64/nontemporal.ll:361
+; CHECK-NEXT:    stnp    d1, d2, [x0, #16]
+; CHECK-NEXT:    stnp    d0, d3, [x0]
+; CHECK-NEXT:    ret
----------------
Should halves work too?


================
Comment at: llvm/test/CodeGen/AArch64/nontemporal.ll:372
+; CHECK-NEXT:    .cfi_startproc
+; CHECK-NEXT:     stnp    q2, q3, [x0, #64]
+; CHECK-NEXT:    stnp    q0, q1, [x0]
----------------
Nit: There's an extra " " here it seems


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72919/new/

https://reviews.llvm.org/D72919