[PATCH] D72974: [mlir] Fix LLVM intrinsic convesion generator for overloadable types.

[River Riddle via Phabricator via llvm-commits]

rriddle added inline comments.


================
Comment at: mlir/tools/mlir-tblgen/LLVMIRIntrinsicGen.cpp:38
+
+// Static free helper functions for accessing tablegen definitions.
+// Return a CodeGen value type entry from a type record.
----------------
Function/top-level comments should be triple tick.


================
Comment at: mlir/tools/mlir-tblgen/LLVMIRIntrinsicGen.cpp:59
+    case llvm::MVT::vAny:
+      OverloadedOps.push_back(R.index());
+      break;
----------------
rriddle wrote:
> Use camelCase for variable names.
This applies to the rest of this revision as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72974/new/

https://reviews.llvm.org/D72974