[PATCH] D71932: [DWARF] Better detect errors in Address Range Tables.
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 17 17:14:48 PST 2020
dblaikie added a comment.
In D71932#1827849 <https://reviews.llvm.org/D71932#1827849>, @ikudrin wrote:
> Thanks for the review!
>
> In D71932#1827601 <https://reviews.llvm.org/D71932#1827601>, @dblaikie wrote:
>
> > Looks good - future work done as separate patches for separable changes/diagnostics would probably be good (& if you've got some broader goals in terms of what functionality you need/would like in llvm-dwarfdump, an email to llvm-dev explaining the broader goals (do they overlap with James Henderson's goals, improving the line table error handling?) would probably be good - to link to in future reviews, etc)
>
>
> My main intention is to add support for 64-bit DWARF.
Ah, cool - thanks for that! (out of curiosity, but by no means necessary - what's the motivation for that? LLVM doesn't currently produce 64-bit DWARF, I think & haven't seen any user-requests/had any discussions about adding it that I recall, but I might've missed some. Useful to know what companies/projects/etc are interested in these things, if there's more context you'd like to share)
> All other changes are just accompanying the main goal, like fixing issues when I found them or making other small improvements. I believe there should be no conflicts with James Henderson's changes.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71932/new/
https://reviews.llvm.org/D71932
More information about the llvm-commits
mailing list