[PATCH] D72967: [MLIR] LLVM dialect: modernize and cleanups

[River Riddle via Phabricator via llvm-commits]

rriddle added a comment.

In D72967#1827793 <https://reviews.llvm.org/D72967#1827793>, @flaub wrote:

> I'm not sure this is a net-win because of the less effective error messages, but I thought I'd submit this and see what happens.


See my other comment. I think we can easily fixup the error messages to be more effective, by:
a) Using the attribute name in the message
b) Using llvm::getTypeName<> to print the c++ type of the expected attribute


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72967/new/

https://reviews.llvm.org/D72967