[PATCH] D72967: [MLIR] LLVM dialect: modernize and cleanups

[River Riddle via Phabricator via llvm-commits]

rriddle accepted this revision.
rriddle added inline comments.
This revision is now accepted and ready to land.


================
Comment at: mlir/test/Dialect/LLVMIR/invalid.mlir:203
   // type of the op as the (wrong) attribute type.
-  // expected-error at +1 {{expected an array attribute}}
+  // expected-error at +1 {{invalid kind of attribute specified}}
   llvm.extractvalue %b 0 : i32 : !llvm<"{i32}">
----------------
Random note, it'd be nice to fix this error message to be a bit more helpful(not in this revision). We could likely use llvm::getTypeName<AttrT> inside of the parser to at least give the expected attribute class name.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72967/new/

https://reviews.llvm.org/D72967